Review Request 125515: Preserve relative link targets when copying symlinks.
Frank Reininghaus
frank78ac at googlemail.com
Thu Oct 22 16:32:05 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125515/#review87274
-----------------------------------------------------------
Ship it!
4096 bytes looks reasonable. I think I would still find a fail-safe solution with a dynamically increasing buffer prettier, but it's so extremely unlikely that this will ever cause problems that it's not worth arguing about it :-)
- Frank Reininghaus
On Okt. 10, 2015, 3:29 nachm., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125515/
> -----------------------------------------------------------
>
> (Updated Okt. 10, 2015, 3:29 nachm.)
>
>
> Review request for KDE Frameworks.
>
>
> Bugs: 352927
> https://bugs.kde.org/show_bug.cgi?id=352927
>
>
> Repository: kio
>
>
> Description
> -------
>
> BUG: 352927
> REVIEW: 125515
> Change-Id: I7d3c988da32cae9d14750c8adb9ca5af6d140572
>
>
> Diffs
> -----
>
> autotests/jobtest.h ef8c3e111ec647cc59c5a9715ab3220ce1651c9e
> autotests/jobtest.cpp c24bcead70f78f2bec3b938819fb2fa842e937d5
> src/ioslaves/file/file.cpp a0a533c957628b00eff175a949685d4497c5f095
>
> Diff: https://git.reviewboard.kde.org/r/125515/diff/
>
>
> Testing
> -------
>
> 2 unit tests added
>
>
> Thanks,
>
> David Faure
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151022/e8cfe99f/attachment.html>
More information about the Kde-frameworks-devel
mailing list