Review Request 125756: Initialize QFunctionPointer to nullptr

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125756/#review87260
-----------------------------------------------------------



src/declarativeimports/core/windowthumbnail.h (lines 128 - 129)
<https://git.reviewboard.kde.org/r/125756/#comment59937>

    AFAIK we are not yet allowed to use nullptr in frameworks. You need to use Q_NULLPTR which gets turned into nullptr if available in the compiler settings.
    
    Also I think header initialization is not yet allowed, so please move to cpp file.
    
    Meh, I want full C++11 on Linux only code.


- Martin Gräßlin


On Oct. 22, 2015, 2 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125756/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 2 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Need to initialize QFunctionPointer to nullptr because otherwise it's used unitialized
> causing m_eglCreateImageKHR check to pass and crashing plasmashell because of invalid call.
> Look at xcbWindowToTextureEGL function in src/declarativeimports/core/windowthumbnail.cpp
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/windowthumbnail.h 576b053229a8cfc15b6fadd8d4e6ff07f937565d 
> 
> Diff: https://git.reviewboard.kde.org/r/125756/diff/
> 
> 
> Testing
> -------
> 
> Verified that plasmashell doesn't crash anymore.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151022/a7655d69/attachment.html>