Review Request 125736: Add Skip Window Close Animation to KWindowEffects

Boudhayan Gupta bgupta at kde.org
Wed Oct 21 15:25:41 UTC 2015



> On Oct. 21, 2015, 8:08 p.m., Martin Gräßlin wrote:
> > src/kwindoweffects.h, line 172
> > <https://git.reviewboard.kde.org/r/125736/diff/3/?file=412098#file412098line172>
> >
> >     looks like you removed an empty line
> 
> Boudhayan Gupta wrote:
>     I don't understand this issue. Removed an empty line?

Re-checked in two text-editors - I added a new line at end of file, not removed an empty line. Seems like a reviewboard issue.


- Boudhayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125736/#review87206
-----------------------------------------------------------


On Oct. 21, 2015, 8:53 p.m., Boudhayan Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125736/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 8:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Adds a Skip Window Close Animation effect to KWindowEffects, with an implementation for X11.
> 
> Binary compatibility with older plugins is **not** preserved. I welcome comments on how exactly to do this - creating a new base class (KWindowEffectsPrivate2 based on KWindowEffectsPrivate and basing the plugins off that sounds kind of complicated). Maybe we can just drop internal ABI compatibility and update kwayland-integration to implement the new method too?
> 
> 
> Diffs
> -----
> 
>   autotests/kwindoweffectstest.cpp 0e83bdc 
>   src/CMakeLists.txt 1598b4f 
>   src/kwindoweffects.h bf0ea1e 
>   src/kwindoweffects.cpp 0c6600f 
>   src/kwindoweffects_dummy.cpp 65924ae 
>   src/kwindoweffects_dummy_p.h 2beabdd 
>   src/kwindoweffects_extensions_p.h PRE-CREATION 
>   src/platforms/xcb/atoms_p.h b5a6e7e 
>   src/platforms/xcb/kwindoweffects.cpp c8da6d2 
>   src/platforms/xcb/kwindoweffects_x11.h c240ddf 
> 
> Diff: https://git.reviewboard.kde.org/r/125736/diff/
> 
> 
> Testing
> -------
> 
> * make test succeeds with the new plugin installed
> * make test succeeds on all tests in the kwindoweffects test except the skipCloseAnimation unit with the old plugin installed. skipCloseAnimation segfaults.
> 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151021/e4a5c27a/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list