Review Request 125656: Drop empty files

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125656/#review87212
-----------------------------------------------------------


Out of curiosity, why was it made only of commented functions? Is it something which was not working and meant to be fixed (but never done) long time ago?

- Luigi Toscano


On Oct. 21, 2015, 4:57 p.m., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125656/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 4:57 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Currently the file src/core/upload.cpp is under a LGPL-2 only license, and
> shipping the corresponding full license is required. Which is incompatible
> with the current frameworks policy. The mentioned file and the private header
> src/core/upload_p.h are currently "empty", as they contain only commented out
> functions. And these files are not part of the API, so it's safe to drop them.
> 
> 
> Diffs
> -----
> 
>   src/core/upload.cpp 486129b55bb108f965050ecc25df7e6d98bebb9e 
>   src/core/upload_p.h 4fa38689f64a0dec94666962a7541dd3d6086482 
> 
> Diff: https://git.reviewboard.kde.org/r/125656/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151021/fec8710c/attachment.html>