Review Request 125681: Correctly set the printSetting's parent

[Robby Stephenson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125681/
-----------------------------------------------------------

(Updated Oct. 20, 2015, 11:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Changes
-------

Submitted with commit ea06177577e0eb53d047e7249ae9e3a92c040e5b by Robby Stephenson to branch master.


Repository: khtml


Description
-------

Avoid setting printSettings as its own parent. It should properly be
owned by the print dialog, which seems to have been the intent in KDE4.


Diffs
-----

  src/khtmlview.cpp d9bbc38b1677a3faf3be46ccc3a211c8d7289e45 

Diff: https://git.reviewboard.kde.org/r/125681/diff/


Testing
-------

Tellico's printing (which uses KHTMLPart) no longer hangs, but works properly.


Thanks,

Robby Stephenson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151020/496e15b3/attachment.html>