Review Request 125720: set default theme to breeze rather than oxygen

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125720/#review87155
-----------------------------------------------------------

Ship it!



src/kicontheme.cpp (line 545)
<https://git.reviewboard.kde.org/r/125720/#comment59890>

    While you are at it, please use QStringLiteral.


- Christoph Feck


On Oct. 20, 2015, 9:52 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125720/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 9:52 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Christoph Feck.
> 
> 
> Bugs: 336739
>     https://bugs.kde.org/show_bug.cgi?id=336739
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> Other framework defaults use Breeze (colors, style..) but icons were still
> oxygen, making theming in Qt native applications seem off when using the
> frameworkintegartion plugin while not running inside a session that was
> coerced into Breeze theming by the kde4breeze theme.
> This notably applies to rooted applications that operate on a different
> $HOME but might still be made to load the KDE platformtheme plugin.
> 
> The breeze icon theme internally uses oxygen as a fallback, so even if
> an icon is missing in breeze we will continue to find it with breeze
> as default.
> 
> BUG: 336739
> 
> 
> Diffs
> -----
> 
>   src/kicontheme.cpp d0ab4b94b69679fba08131d0b0b577247b8db46b 
> 
> Diff: https://git.reviewboard.kde.org/r/125720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151020/34277416/attachment.html>