Review Request 125725: Make KCrash optional for kservice

Christoph Cullmann cullmann at kde.org
Tue Oct 20 14:00:17 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125725/
-----------------------------------------------------------

(Updated Oct. 20, 2015, 2 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks and David Faure.


Repository: kservice


Description
-------

kservice depends on KCrash only for kbuildsycoca.
make this optional and link only against it, if around. Move check to kbuildsyscoca file.


Diffs
-----

  CMakeLists.txt 4c0f269 
  src/kbuildsycoca/CMakeLists.txt 19bdc84 
  src/kbuildsycoca/kbuildsycoca_main.cpp 03619cc 

Diff: https://git.reviewboard.kde.org/r/125725/diff/


Testing
-------

Seems to compile fine without it.


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151020/2d3e65fc/attachment.html>


More information about the Kde-frameworks-devel mailing list