Review Request 125711: Use deleteLater in Part::slotWidgetDestroyed().

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125711/#review87109
-----------------------------------------------------------

Ship it!


Looks good to me, and I might even backport to KDE 4's kdelibs so that I can finally click on slashdot RSS feeds without crashing akregator (if this is that same bug, that is)...

- Michael Pyne


On Oct. 19, 2015, 7:58 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125711/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 7:58 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kparts
> 
> 
> Description
> -------
> 
> When a part's main widget is destroyed, we should not delete the part
> immediately - both because deleting an object from inside one of its
> signals is not safe generally, and because derived classes may well hold
> QPointers to the widgets, expecting them to be cleared between the
> widget being destroyed and the part being destroyed.
> 
> 
> Diffs
> -----
> 
>   autotests/parttest.cpp c477face2f0f94f1d66deadedb4bc913eaa21842 
>   src/part.cpp 4a3150e8aa2a6ed2aff68c945135b3536db2059d 
> 
> Diff: https://git.reviewboard.kde.org/r/125711/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for KParts pass.
> 
> Running akregator under valgrind no longer produces a bunch of "invalid reads" from KHTMLPart when switching around between articles.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151020/268a6a61/attachment.html>