Review Request 125164: Fix misbehavior when canceling a job
Albert Astals Cid
aacid at kde.org
Mon Oct 19 17:44:08 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125164/#review87091
-----------------------------------------------------------
Is this trying to fix something similar to https://git.reviewboard.kde.org/r/125613/diff/ ?
- Albert Astals Cid
On set. 11, 2015, 1:24 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125164/
> -----------------------------------------------------------
>
> (Updated set. 11, 2015, 1:24 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Catch that the job has been cancelled and emit the job as finished.
>
> Still, I'm not too sure it's the correct fix.
>
>
> Diffs
> -----
>
> autotests/jobtest.h ef8c3e1
> autotests/jobtest.cpp c24bcea
> src/core/transferjob.cpp 0c38070
>
> Diff: https://git.reviewboard.kde.org/r/125164/diff/
>
>
> Testing
> -------
>
> Added a test and made it pass.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151019/f7c09d89/attachment.html>
More information about the Kde-frameworks-devel
mailing list