Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125521/#review87050
-----------------------------------------------------------



src/kdropwidgetdecorator.h (line 37)
<https://git.reviewboard.kde.org/r/125521/#comment59834>

    Indeed this isn't a decorator (unlike KDragWidgetDecorator), and there's nothing specific about QTabBar in this code (other than the docu).
    
    In fact I don't understand how one is supposed to use this widget in the first place... in a stacked widget? or?
    
    Please add usage documentation (or tell us here), then I might have some feedback on the naming and/or on the design ;-)


- David Faure


On Oct. 10, 2015, 10:55 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125521/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2015, 10:55 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Christoph Feck, and David Faure.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kdropwidgetdecorator.h PRE-CREATION 
>   src/kdropwidgetdecorator.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125521/diff/
> 
> 
> Testing
> -------
> 
> It builds, the headers I expect are in the right places, etc. I just noticed I'm not exporting the class though, will fix that and reupload.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151019/16c89b09/attachment.html>