Review Request 125681: Correctly set the printSetting's parent

[Robby Stephenson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125681/
-----------------------------------------------------------

(Updated Oct. 18, 2015, 8:58 p.m.)


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Changes
-------

Create the dialog first, then use it as the printSetting parent


Repository: khtml


Description
-------

Avoid setting printSettings as its own parent. It should properly be
owned by the print dialog, which seems to have been the intent in KDE4.


Diffs (updated)
-----

  src/khtmlview.cpp d9bbc38b1677a3faf3be46ccc3a211c8d7289e45 

Diff: https://git.reviewboard.kde.org/r/125681/diff/


Testing
-------

Tellico's printing (which uses KHTMLPart) no longer hangs, but works properly.


Thanks,

Robby Stephenson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151018/cd15063d/attachment.html>