Review Request 125688: Make KNotifications dep in KIO (kpac) optional

[Christoph Cullmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125688/
-----------------------------------------------------------

(Updated Oct. 18, 2015, 4:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
-------

Submitted with commit d3164ae9832bef4a9768ff8c388eda92af51a039 by Christoph Cullmann to branch master.


Repository: kio


Description
-------

Make KNotifications dep in KIO (kpac) optional.

I am not sure if the notifications are at all very useful, given the user won't understand what they are about in 99% of the cases.


Diffs
-----

  src/kpac/CMakeLists.txt fc6043f 
  src/kpac/proxyscout.cpp 972dde2 

Diff: https://git.reviewboard.kde.org/r/125688/diff/


Testing
-------

Compiles and run with and without the dep around.
Missed this dep. first as it is only for this subtool :(


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151018/ee0bfc7c/attachment-0001.html>