Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

David Rosca nowrep at gmail.com
Sun Oct 18 16:09:42 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125691/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kio


Description
-------

If qMimeType is empty, addToMimeAppsList shouldn't be called.


Diffs
-----

  src/widgets/kopenwithdialog.cpp c60a193 

Diff: https://git.reviewboard.kde.org/r/125691/diff/


Testing
-------

opening new KOpenWithDialog() without mimeType and typing eg "dolphin" to exec line now correctly returns valid KService.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151018/c0ae39e5/attachment.html>


More information about the Kde-frameworks-devel mailing list