Review Request 125688: Make KNotifications dep in KIO (kpac) optional

Christoph Cullmann cullmann at kde.org
Sun Oct 18 13:09:56 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125688/
-----------------------------------------------------------

Review request for KDE Frameworks and David Faure.


Repository: kio


Description
-------

Make KNotifications dep in KIO (kpac) optional.

I am not sure if the notifications are at all very useful, given the user won't understand what they are about in 99% of the cases.


Diffs
-----

  src/kpac/CMakeLists.txt fc6043f 
  src/kpac/proxyscout.cpp 972dde2 

Diff: https://git.reviewboard.kde.org/r/125688/diff/


Testing
-------

Compiles and run with and without the dep around.
Missed this dep. first as it is only for this subtool :(


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151018/48a3ab9e/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list