Review Request 125619: Refactor KNewPasswordDialog class

[Elvis Angelaccio]

> On Oct. 13, 2015, 1:33 p.m., Aleix Pol Gonzalez wrote:
> > File Attachment: knewpassworddialog4.png - knewpassworddialog4.png
> > <https://git.reviewboard.kde.org/r/125619/#fcomment490>
> >
> >     Shouldn't it have a red background when empty as well?
> 
> Elvis Angelaccio wrote:
>     I'm not sure honestly. Wouldn't be a little weird to have a red background there and a white one below in the verification field?
>     Actually your question makes me wonder another thing: should we hide the verification field initially? Would make sense to show it only after the user starts typing the password?
>     
>     What the usability guys think?
> 
> Thomas Pfeiffer wrote:
>     The background should not be red before the user even started typing. Red indicates something is wrong, but the field being empty before the user started typing is perfectly fine.
>     It should only be red if the user clears the field again after having typed, with the message "Password cannot be empty"

> The background should not be red before the user even started typing. Red indicates something is wrong, but the field being empty before the user started typing is perfectly fine.
It should only be red if the user clears the field again after having typed, with the message "Password cannot be empty"

I agree, but probably it's better to implement this in a separate patch. There are already enough changes here, we have to be sure first that this patch does not introduce regressions in KNewPasswordDialog.


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125619/#review86806
-----------------------------------------------------------


On Oct. 13, 2015, 1:33 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125619/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 1:33 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David Faure.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Follow-up of the KNewPasswordWidget review.
> By introducing a KNewPasswordWidget in the .ui file, we can:
> 
> - remove the code that has been moved to KNewPasswordWidget
> - enable the KNewPasswordWidget additional features
> 
> The only feature that is currently not available is the ability to remove the strength bar. Do we want to allow developers to show a KNewPasswordDialog without a strenght bar?
> 
> 
> Diffs
> -----
> 
>   src/knewpassworddialog.h 1ac7b2151f1e88681a15ce21465449cedb871f1e 
>   src/knewpassworddialog.cpp bd7459acf3c72bc6dc0711da6086213d5111d5c3 
>   src/knewpassworddialog.ui 55a1f62cf4ba6d6c87b2c47742ba3bcd531ebfe8 
> 
> Diff: https://git.reviewboard.kde.org/r/125619/diff/
> 
> 
> Testing
> -------
> 
> Trying to insert a password which is too short or too weak or empty, works as expected.
> 
> 
> File Attachments
> ----------------
> 
> knewpassworddialog1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/62bf21f6-1dcf-46c3-8b1d-146500b5f629__knewpassworddialog1.png
> knewpassworddialog2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/b2e2666f-ce19-4df3-b6ba-25c13fc370ae__knewpassworddialog2.png
> knewpassworddialog3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/b9536088-0cc4-470b-a211-6db4ca79aa2f__knewpassworddialog3.png
> knewpassworddialog4.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/13/4f826716-9ed2-4ecb-8cbe-4fb50abf1086__knewpassworddialog4.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151018/936fbab5/attachment.html>