Review Request 125616: Make doctools + wallet optional
David Faure
faure at kde.org
Sun Oct 18 12:18:15 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125616/#review87014
-----------------------------------------------------------
Ship it!
src/kpasswdserver/kpasswdserver.cpp (line 814)
<https://git.reviewboard.kde.org/r/125616/#comment59818>
you could also just move down this line into the next #ifdef block, to merge them.
- David Faure
On Oct. 18, 2015, 10:43 a.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125616/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2015, 10:43 a.m.)
>
>
> Review request for KDE Frameworks, Alex Merry and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Make doctools + wallet optional.
>
>
> Diffs
> -----
>
> CMakeLists.txt cfea7b2
> src/ioslaves/help/CMakeLists.txt 3f07f31
> src/kpasswdserver/CMakeLists.txt c9f49a5
> src/kpasswdserver/kpasswdserver.h 9dc56ce
> src/kpasswdserver/kpasswdserver.cpp 24a3a17
>
> Diff: https://git.reviewboard.kde.org/r/125616/diff/
>
>
> Testing
> -------
>
> Still compiles all stuff if all deps are around
>
>
> Thanks,
>
> Christoph Cullmann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151018/7efeb4ff/attachment.html>
More information about the Kde-frameworks-devel
mailing list