Review Request 125616: Make doctools + wallet optional

[Christoph Cullmann]

> On Oct. 18, 2015, 9:49 a.m., David Faure wrote:
> > src/kpasswdserver/CMakeLists.txt, line 9
> > <https://git.reviewboard.kde.org/r/125616/diff/2/?file=410735#file410735line9>
> >
> >     I think it would make more sense to have ifdef HAVE_KWALLET in kpasswdserver.cpp, because kpasswdserver is useful even without kwallet: it stores (http) passwords in memory while it's running, which allows to avoid typing the same password 1000 times when browsing an HTTP site with auth.
> >     
> >     KWallet allows to store that to disk so it's remembered after a reboot, but that's just a bonus. The primary function of kpasswdserver is the in-memory storage.

Ok, true, will change that!


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125616/#review87004
-----------------------------------------------------------


On Oct. 17, 2015, 12:04 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125616/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2015, 12:04 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Make doctools + wallet optional.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt cfea7b2 
>   src/ioslaves/help/CMakeLists.txt 3f07f31 
>   src/kpasswdserver/CMakeLists.txt c9f49a5 
> 
> Diff: https://git.reviewboard.kde.org/r/125616/diff/
> 
> 
> Testing
> -------
> 
> Still compiles all stuff if all deps are around
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151018/6e08ce66/attachment-0001.html>