Review Request 125615: Make phonon dependency optional

Christoph Cullmann cullmann at kde.org
Sun Oct 18 08:50:08 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125615/
-----------------------------------------------------------

(Updated Oct. 18, 2015, 8:50 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Sune Vuorela.


Changes
-------

Submitted with commit 0c0cb0ab8119b399ef21c601990bc294d5dd84bc by Christoph Cullmann to branch master.


Repository: knotifications


Description
-------

Make phonon dependency optional, purely internal change, like it is done for speech.


Diffs
-----

  CMakeLists.txt 5a4ec83 
  src/CMakeLists.txt 2a88b5a 
  src/knotificationmanager.cpp 1c392b4 

Diff: https://git.reviewboard.kde.org/r/125615/diff/


Testing
-------

Still builds with (and now even without) phonon here.


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151018/25302a3f/attachment.html>


More information about the Kde-frameworks-devel mailing list