Review Request 125681: Correctly set the printSetting's parent
Robby Stephenson
robby at periapsis.org
Sun Oct 18 01:13:12 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125681/
-----------------------------------------------------------
Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
Repository: khtml
Description
-------
Avoid setting printSettings as its own parent. It should properly be
owned by the print dialog, which seems to have been the intent in KDE4.
Diffs
-----
src/khtmlview.cpp d9bbc38b1677a3faf3be46ccc3a211c8d7289e45
Diff: https://git.reviewboard.kde.org/r/125681/diff/
Testing
-------
Tellico's printing (which uses KHTMLPart) no longer hangs, but works properly.
Thanks,
Robby Stephenson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151018/f6722f20/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list