Review Request 125598: Allow KConfig to use resources as fallback config files

[Christoph Cullmann]

> On Oct. 17, 2015, 12:23 p.m., David Faure wrote:
> > I have no opinion on /kconfig vs /kconfig5. It's internal, we can fix it at any time, so whether we change it now, or for kf6, or never... makes no difference.

I use /kconfig then, and it is not that internal, e.g. as soon as KTextEditor will now use it that way for its bundled configs, that will break badly if we change this again ;=)


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125598/#review86960
-----------------------------------------------------------


On Oct. 17, 2015, 12:01 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125598/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2015, 12:01 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> Like KXMLGui, KConfig has now a fallback to config files bundled with the application in resources.
> 
> Like kxmlgui, its in :/kconfig5.
> 
> This allows e.g. KTextEditor deployment without any installed files beside the library itself and should easy the shipping of default configs for non-linux/unix platforms.
> 
> Question is if :/kconfig5 is that nice a prefix, at least it is unique and matches what we do with kxmlgui5.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 8213bc4 
>   autotests/fallbackconfigresources.qrc PRE-CREATION 
>   autotests/fallbackconfigresourcestest.cpp PRE-CREATION 
>   src/core/kconfig.cpp 7f03869 
> 
> Diff: https://git.reviewboard.kde.org/r/125598/diff/
> 
> 
> Testing
> -------
> 
> Added an unit test to show that the fallback resource is found and read.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151017/8bbc486e/attachment.html>