Review Request 125332: Use the more advanced version of uriencode.cmake from kdoctools which supports Windows.
Luigi Toscano
luigi.toscano at tiscali.it
Thu Oct 15 10:03:33 UTC 2015
> On Oct. 8, 2015, 2:59 p.m., Aleix Pol Gonzalez wrote:
> > +1
>
> Hannah von Reth wrote:
> Ship it?
See my comment below: "Is FindPerlModules really not needed?"
It is missing from the last version of the patch, is it intended?
- Luigi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125332/#review86501
-----------------------------------------------------------
On Oct. 8, 2015, 2:30 p.m., Hannah von Reth wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125332/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 2:30 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs4support
>
>
> Description
> -------
>
> Use the more advanced version of uriencode.cmake from kdoctools which supports Windows.
>
>
> Diffs
> -----
>
> cmake/uriencode.cmake fde06d3ccf14212122bbee583b44158a2411fbcf
> src/CMakeLists.txt 14cc57413b827286ba1d29ccf31e308b05c52413
>
> Diff: https://git.reviewboard.kde.org/r/125332/diff/
>
>
> Testing
> -------
>
> Windows
>
>
> Thanks,
>
> Hannah von Reth
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151015/274b04d3/attachment.html>
More information about the Kde-frameworks-devel
mailing list