Review Request 125628: KTempDir: Make sense out of s_umask initialization

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125628/
-----------------------------------------------------------

(Updated Oct. 15, 2015, 1:33 a.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Repository: kdelibs4support


Description
-------

Since my Qt rebuild from today, I started having crashes when starting some Qt processes (namely kcminit and another I can't remember). Both KCrash backtraces pointed to this code.

I don't know why it didn't crash before, but the code doesn't make much sense to me. This patch tailors kStoreUmask to what it is requested to do. I guess this code was refactored and the return is an ancient, unfortunate leftover.


Diffs
-----

  src/kdecore/ktempdir.cpp 1240ac7 

Diff: https://git.reviewboard.kde.org/r/125628/diff/


Testing
-------

Tests still pass, my system starts reliably.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151014/af0f5e1e/attachment-0001.html>