Review Request 125621: Missing color initialization in KNewPasswordWidget
Elvis Angelaccio
elvis.angelaccio at kdemail.net
Tue Oct 13 13:47:35 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125621/
-----------------------------------------------------------
Review request for KDE Frameworks and Christoph Feck.
Repository: kwidgetsaddons
Description
-------
While working on RR [125619](https://git.reviewboard.kde.org/r/125619/) I discovered a missing initialization in KNewPasswordWidget.
We need to initialize the "warning color" to the default background color, otherwise if `setBackgroundWarningColor()` is not called, that color will be black.
Diffs
-----
src/knewpasswordwidget.cpp 215cd206962dc57d0d05366e66d1729b45e7d956
Diff: https://git.reviewboard.kde.org/r/125621/diff/
Testing
-------
Showing a KNewPasswordWidget, without calling `setBackgroundWarningColor()`, does not show a black "warning color" anymore.
Thanks,
Elvis Angelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151013/cd4ddfc8/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list