phonon dep in knotifications

[Christoph Cullmann]

Hi,

> On Mon, Oct 12, 2015 at 4:05 PM, Christoph Cullmann < cullmann at absint.com >
> wrote:
> 
> 
>> On 2015-10-12, Christoph Cullmann < cullmann at absint.com > wrote:
>>> Hi,
>>> 
>>> I would like to make this dependency optional.
>>> Would that be ok? Is not that much work, but if it is not wanted, don't want to
>>> waste my time.
>>> E.g. on Win/Mac its a real hassle to build and most applications don't need it
>>> anyway but
>>> might depend on knotifications.
>> 
>> I think it makes sense to make it optional. Added points if it can be
>> optional in a api/abi compliant way.
> Hi,
> 
> there you go:
> 
> https://git.reviewboard.kde.org/r/125615/
> 
> API + ABI compatible ;=)
> 
> One hack less for Win/Mac.
> 
> Thanks for your work.
> 
> One thing that makes me a bit sad is that this all went down without
> actually giving any chance to the maintainer to have any say.
> 
> Please let's not ignore the maintainers.
Yeah, your are right :/
Sorry.

Could you take a look at my last mail in the "Policy for Dependencies" thread?

I will reopen the review request.

Greetings
Christoph

-- 
----------------------------- Dr.-Ing. Christoph Cullmann ---------
AbsInt Angewandte Informatik GmbH      Email: cullmann at AbsInt.com
Science Park 1                         Tel:   +49-681-38360-22
66123 Saarbrücken                      Fax:   +49-681-38360-20
GERMANY                                WWW:   http://www.AbsInt.com
--------------------------------------------------------------------
Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234