Review Request 125615: Make phonon dependency optional

[Martin Klapetek]

> On Oct. 13, 2015, 4:26 a.m., Martin Klapetek wrote:
> > As a maintainer, I would be much much more happy if it actually had a check for win/mac rather than making audio notifications optional always. Also speaking as someone who deals with knotifications bug reports.
> 
> Martin Klapetek wrote:
>     ...and I'm sure there will be one about no sound in notifications in Plasma sooner or later, which I would like to avoid.
>     
>     (pressed enter too soon)
> 
> Sune Vuorela wrote:
>     I like that things that aren't actually specific to an OS aren't marked as such, though one could also argue that it should be required unless passed -DDISABLE_PHONON or similar to cmake.
> 
> Christoph Cullmann wrote:
>     Hi, I am pragmatic, I can guard it with "optional only on mac and win" (btw., no, you can't just remove the dep there, as you can build phonon if you really want on both platforms), but I don't think that is the right way. Neither the "-DISABLE..".
>     
>     If we want to make frameworks attractive, it must be easy to build them and easy to bundle them with your application.
>     
>     With the optional dependency it is.
>     
>     If people build from source, you can anyway not avoid that they just compile a broken phonon or enable the -DISABLE.. switch.
> 
> Albert Astals Cid wrote:
>     I think -DDISABLE_PHONON or similar (-DMAKE_PHONON_OPTIONAL) is the easiest way to make it so that people that don't want the dependency can still build but that it is a conscious decision so there's fewer people that complain later at a "no sounds in Plasma" level.
> 
> Christoph Cullmann wrote:
>     But do we start to add such switches then for everything that we want to have optional? And how to document that? If we add just the hint to this switch to the description, people will just copy it and miscompile, too.
>     If we want to have our frameworks attractive for any non-linux person, I don't think that is the way to go.

> I like that things that aren't actually specific to an OS aren't marked as such

The original proposal did mention "hassle on win/mac", so I understood the purpose of this patch to only allow easier building/bundling on win/mac.

> Hi, I am pragmatic

Hi, I'm the maintainer who will be dealing with the bugs/issues this causes, which is virtually all event sounds in your desktop not working _and_ not working without any apparent trouble (the sound is configured, the sound plays in the config etc). I appreciate the effort of wanting to make the frameworks more attractive to non-linux, but my job as a maintainer is to ensure things are bulletproof-good for current users, which are mostly linux/plasma ones. This is not entirely the best solution and it will break and I'll be the one dealing with it and I'd like to avoid it if possible. Which it is.

> But do we start to add such switches then for everything that we want to have optional?

I don't really want to have the sound optional though, at least not in Plasma; the audio part of KNotification is what plays the sound with various dialogs as well as the logout sound (and yes, people actually still do file reports for missing login/logout sound which wasn't there till 5.3 I think). So in this case, I think such switch would be better.

But maybe I'm all wrong and no distro will actually break this (though looking at how ktp 15.08 went, I'm not hopeful at all). So tell you what, let's leave this in, but when a bug report about a missing sound arrives, I'll change it away to use a switch.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125615/#review86771
-----------------------------------------------------------


On Oct. 12, 2015, 11:01 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125615/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2015, 11:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Sune Vuorela.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Make phonon dependency optional, purely internal change, like it is done for speech.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5a4ec83 
>   src/CMakeLists.txt 2a88b5a 
>   src/knotificationmanager.cpp 1c392b4 
> 
> Diff: https://git.reviewboard.kde.org/r/125615/diff/
> 
> 
> Testing
> -------
> 
> Still builds with (and now even without) phonon here.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151013/cba8796b/attachment.html>