Review Request 125615: Make phonon dependency optional

[Christoph Cullmann]

> On Oct. 12, 2015, 10 p.m., Albert Astals Cid wrote:
> > CMakeLists.txt, line 65
> > <https://git.reviewboard.kde.org/r/125615/diff/1/?file=410713#file410713line65>
> >
> >     This should be part of the summary not here were people won't see it
> 
> Christoph Cullmann wrote:
>     You are right, will fix that tomorrow. Will do that for the speech integration, too.

http://commits.kde.org/knotifications/7fbff127952f1f83864e07eb054c1a75e460a406

you get now:

-- The following OPTIONAL packages have not been found:

 * Qt5TextToSpeech , Qt text to speech module
   Required to build text to speech notification support
 * Phonon4Qt5 (required version >= 4.6.60) , Qt-based audio library
   Required to build audio notification support


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125615/#review86762
-----------------------------------------------------------


On Oct. 12, 2015, 9:01 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125615/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2015, 9:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Sune Vuorela.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Make phonon dependency optional, purely internal change, like it is done for speech.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5a4ec83 
>   src/CMakeLists.txt 2a88b5a 
>   src/knotificationmanager.cpp 1c392b4 
> 
> Diff: https://git.reviewboard.kde.org/r/125615/diff/
> 
> 
> Testing
> -------
> 
> Still builds with (and now even without) phonon here.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151013/e53c6428/attachment.html>