Review Request 124963: New widget: KNewPasswordWidget

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124963/
-----------------------------------------------------------

(Updated Oct. 12, 2015, 5:01 p.m.)


Review request for KDE Frameworks and Christoph Feck.


Changes
-------

Fixed qBounds + tests. Removed unnecessary isVisible() call.


Repository: kwidgetsaddons


Description
-------

This widget is a stripped-down version of KNewPasswordDialog, without any dialog-specific stuff.

### Why a new widget?

This widget is meant to be easily embedded in any custom password dialog, including KNewPasswordDialog. It's the least common denominator of features that any password dialog should offer to the user.

### Features

* Password visibility action (same as RR 124698). The password verification field is hidden if the user shows the password.
* Background warning colour. The password verification field gets a coloured background whenever the password and its verification don't match. (feature borrowed from Keepass)
* Password status signal. This allows the upper level dialogs to update their stuff (enable/disable OK button, show warnings for low password strength, etc.)
* Password strength bar can be hidden.
* Unit test.

### Use cases
At least the following:

* Ark (new archive dialog)
* KNewPasswordDialog refactoring (my next RR if this one gets accepted)


Diffs (updated)
-----

  autotests/CMakeLists.txt ac708ef33e3be89db85d43911f96e536c52f741d 
  autotests/knewpasswordwidgettest.h PRE-CREATION 
  autotests/knewpasswordwidgettest.cpp PRE-CREATION 
  src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
  src/knewpasswordwidget.h PRE-CREATION 
  src/knewpasswordwidget.cpp PRE-CREATION 
  src/knewpasswordwidget.ui PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124963/diff/


Testing
-------


File Attachments
----------------

knewpasswordwidget1.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/5796469c-28b7-4151-b9cb-6a327631db75__knewpasswordwidget1.png
knewpasswordwidget2.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/b3bfc9ac-ab8e-404c-8091-b5ad9e3e054f__knewpasswordwidget2.png
knewpasswordwidget3.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/dfaeea4e-65da-4961-b266-986a21f54ca7__knewpasswordwidget3.png


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151012/d4d5f043/attachment.html>