Review Request 125603: Add function to query standards xml file location

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125603/#review86704
-----------------------------------------------------------

Ship it!



src/kxmlguiclient.cpp (line 216)
<https://git.reviewboard.kde.org/r/125603/#comment59674>

    well, it can't possibly be empty, as you wrote in the documentation ;-) So this if should be removed.


- David Faure


On Oct. 12, 2015, 11:08 a.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125603/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2015, 11:08 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Add function to query the ui_standards.rc location to avoid hardcoding it in kparts and co.
> 
> Static function, guaranteed to return a valid location, given the resource will always be there.
> 
> 
> Diffs
> -----
> 
>   src/kxmlguiclient.h c349602 
>   src/kxmlguiclient.cpp f46e292 
> 
> Diff: https://git.reviewboard.kde.org/r/125603/diff/
> 
> 
> Testing
> -------
> 
> Run unit tests.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151012/2c5bf06b/attachment-0001.html>