Review Request 125603: Add function to query standards xml file location

Christoph Cullmann cullmann at kde.org
Mon Oct 12 11:07:46 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125603/
-----------------------------------------------------------

(Updated Oct. 12, 2015, 11:07 a.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Make the API easier: we are sure, that we always will return some file, now that the resource file is there.


Repository: kxmlgui


Description
-------

Add function to query the ui_standards.rc location to avoid hardcoding it in kparts and co.

Question is: should it be a member as in the diff or a static function? I am fine with both.


Diffs (updated)
-----

  src/kxmlguiclient.h c349602 
  src/kxmlguiclient.cpp f46e292 

Diff: https://git.reviewboard.kde.org/r/125603/diff/


Testing
-------

Run unit tests.


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151012/89794146/attachment.html>


More information about the Kde-frameworks-devel mailing list