Review Request 125595: Alllow kxmlgui framework to be used without any installed files
Christoph Cullmann
cullmann at kde.org
Sun Oct 11 22:01:50 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125595/
-----------------------------------------------------------
(Updated Oct. 11, 2015, 10:01 p.m.)
Review request for KDE Frameworks and David Faure.
Repository: kxmlgui
Description
-------
Bundle the one needed .rc file in a resource.
The patch is now updated to pack all assets of kxmlgui into a resource file, zero installed files needed.
Btw., for HighDPI screens, we might want later to pack at least some 2x image in for the about kde stuff.
Diffs (updated)
-----
src/CMakeLists.txt 949da5e
src/kaboutapplicationpersonlistdelegate_p.cpp 5214288
src/kaboutkdedialog_p.cpp 0261b85
src/kxmlgui.qrc PRE-CREATION
src/kxmlguiclient.cpp 01103ef
Diff: https://git.reviewboard.kde.org/r/125595/diff/
Testing
-------
Bundle ui_standards.rc in a resource, still allow to overwrite it, like before. This makes it possible to use this framework on win/mac without any QStandardPaths patches. This patch is still missing the matching .qrc file, I wanted first to know if that fallback is OK. The idea would be to add this and not install the ui_standards.rc by default and only compile it in.
Thanks,
Christoph Cullmann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151011/397bd1ef/attachment.html>
More information about the Kde-frameworks-devel
mailing list