Review Request 125556: Install CamelCase headers
David Faure
faure at kde.org
Sun Oct 11 21:03:18 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125556/#review86673
-----------------------------------------------------------
This fix looks good to me, but I see an inconsistency overall:
src/CMakeLists.txt (line 24)
<https://git.reviewboard.kde.org/r/125556/#comment59657>
Well, then the lib itself shouldn't be called KF5MediaWiki?
But of course changing this is only possible if it hasn't been released yet.
- David Faure
On Oct. 11, 2015, 7:46 p.m., Dāvis Mosāns wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125556/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2015, 7:46 p.m.)
>
>
> Review request for KDE Frameworks and Adrián Chaves Fernández.
>
>
> Repository: libmediawiki
>
>
> Description
> -------
>
> They were generated but wasn't installed.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt a8e095ab0a5eaf86c2fc3b5035ef5d476b899023
>
> Diff: https://git.reviewboard.kde.org/r/125556/diff/
>
>
> Testing
> -------
>
> Compiles and headers are installed.
>
>
> Thanks,
>
> Dāvis Mosāns
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151011/67bb861c/attachment.html>
More information about the Kde-frameworks-devel
mailing list