Review Request 125325: New widget KCollapsibleGroupBox

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review86639
-----------------------------------------------------------



src/CMakeLists.txt (line 12)
<https://git.reviewboard.kde.org/r/125325/#comment59639>

    Please keep alphabetic order



src/kcollapsiblegroupbox.h (line 36)
<https://git.reviewboard.kde.org/r/125325/#comment59642>

    "When expanded, the widget ..."



src/kcollapsiblegroupbox.h (line 44)
<https://git.reviewboard.kde.org/r/125325/#comment59640>

    Since this property can be changed by the user, I expected a signal/NOTIFY method.



src/kcollapsiblegroupbox.h (line 51)
<https://git.reviewboard.kde.org/r/125325/#comment59641>

    Typos -> "permanently shown"



src/kcollapsiblegroupbox.h (line 70)
<https://git.reviewboard.kde.org/r/125325/#comment59643>

    Add ',' after "animations".



src/kcollapsiblegroupbox.cpp (line 43)
<https://git.reviewboard.kde.org/r/125325/#comment59644>

    Is it really possible to give default values for members in the class declaration? If yes, it is a new C++11 feature that we can assume for frameworks?



src/kcollapsiblegroupbox.cpp (line 105)
<https://git.reviewboard.kde.org/r/125325/#comment59645>

    d->isExpanded = expanded;
    
    looks simpler to understand?



src/kcollapsiblegroupbox.cpp (line 145)
<https://git.reviewboard.kde.org/r/125325/#comment59646>

    Space after "0,"


- Christoph Feck


On Oct. 4, 2015, 8:37 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2015, 8:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> -------
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> ----------------
> 
> kcollapsiblegroupbox.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151010/d804bd02/attachment.html>