Review Request 125556: Install CamelCase headers

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125556/#review86634
-----------------------------------------------------------



src/CMakeLists.txt (line 80)
<https://git.reviewboard.kde.org/r/125556/#comment59635>

    The KF5 way for namespaced headers (see e.g. KParts) is to put it all into one subdir, i.e. here it would be
    
    DESTINATION ${KF5_INCLUDE_INSTALL_DIR}/MediaWiki/mediawiki
    
    and for camel case headers below,
    
    DESTINATION ${KF5_INCLUDE_INSTALL_DIR}/MediaWiki/MediaWiki
    
    This way you can do
    
    target_include_directories(KF5MediaWiki INTERFACE "$<INSTALL_INTERFACE:${KDE_INSTALL_INCLUDEDIR_KF5}/MediaWiki>" )
    and ensure that none of those headers are usable without linking to KF5MediaWiki in the first place.


- David Faure


On Oct. 8, 2015, 3:11 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125556/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 3:11 p.m.)
> 
> 
> Review request for KDE Frameworks and Adrián Chaves Fernández.
> 
> 
> Repository: libmediawiki
> 
> 
> Description
> -------
> 
> They were generated but wasn't installed.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt a8e095ab0a5eaf86c2fc3b5035ef5d476b899023 
> 
> Diff: https://git.reviewboard.kde.org/r/125556/diff/
> 
> 
> Testing
> -------
> 
> Compiles and headers are installed.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151010/9785a4df/attachment.html>