Review Request 125575: Make program logo non-pixelated on HiDPI

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125575/#review86566
-----------------------------------------------------------



src/kaboutapplicationdialog.cpp (line 94)
<https://git.reviewboard.kde.org/r/125575/#comment59606>

    This doesn't seem right. Sorry.
    
    setDevicePixelRatio should really only be done when loading/creating a pixmap that has actually taken the devicePixelRatio into account. 
    
    What your patch is doing is effectively saying; if I have a 32px logo draw me at 32 device pixels on the device no matter what the resolution of the device is. 
    
    So, it won't look pixelated, but it'll also only be quarter of the size on the screen than it will be on a "normal" monitor.


- David Edmundson


On Oct. 9, 2015, 6:07 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125575/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 6:07 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> e.g. the KatePart logo is pixelated (look at help -> about editor component in kate).
> now it looks at least nice.
> 
> An other solution could be to create the pixmap in katepart in the setProgramLogo call, but that will then need adjustments at all places used in other applications, too.
> 
> 
> Diffs
> -----
> 
>   src/kaboutapplicationdialog.cpp f8bfe7b 
> 
> Diff: https://git.reviewboard.kde.org/r/125575/diff/
> 
> 
> Testing
> -------
> 
> Kate without that patch => pixelated logo
> Kate with that patch => nice logo ;)
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151009/dea371d1/attachment.html>