Review Request 125535: Minor optimizations
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Oct 6 15:40:48 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125535/#review86431
-----------------------------------------------------------
+1 LGTM.
- Aleix Pol Gonzalez
On Oct. 6, 2015, 2:44 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125535/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 2:44 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: karchive
>
>
> Description
> -------
>
> A few reserve calls
> A missing &
> QLatin1String -> QStringLiteral
>
>
> Diffs
> -----
>
> src/k7zip.cpp 64c6b52
> src/karchive.cpp a1cd6a8
> src/kfilterdev.cpp 85fa940
> src/ktar.cpp 49a6791
> src/kzip.cpp 6053a3b
>
> Diff: https://git.reviewboard.kde.org/r/125535/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Albert Astals Cid
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151006/9c9b15b6/attachment.html>
More information about the Kde-frameworks-devel
mailing list