Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125537/#review86429
-----------------------------------------------------------

Ship it!


Perfect thanks!

I'll create a new tag to include this in 5.15.

- David Faure


On Oct. 6, 2015, 11:06 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125537/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 11:06 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> In 0e4d7247e27f82a9b79b19dbceb35b603baceb76, a new feature saving directory mtime in ksycoca db is introduced.
> 
> In the related code, TimestampChecker() will check the mtime recursively, but the building process will only read the top level directories' mtime, which causes ksycoca db being recreated again and again.
> 
> I hit this because my ~/.config/menus/applications-merged mtime newer than ~/.config/menus. And plasmashell is running with 100% since it's creating ksycoca db repeatedly.
> 
> This patch change the building db procedure to use the same logic as in TimestampChecker(), so building and checking are consistent now.
> 
> 
> Diffs
> -----
> 
>   autotests/ksycocatest.cpp 67f0700 
>   src/sycoca/kbuildsycoca.cpp 00aaac3 
>   src/sycoca/ksycoca.cpp 5209389 
>   src/sycoca/ksycocautils_p.h c14057b 
> 
> Diff: https://git.reviewboard.kde.org/r/125537/diff/
> 
> 
> Testing
> -------
> 
> Now a sub directory with larger timestamp than parent will not cause ksycoca data being recreated again and again.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151006/838db278/attachment.html>