Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

[Emmanuel Pescosta]

> On Oct. 6, 2015, 10:27 a.m., Aleix Pol Gonzalez wrote:
> > src/ioslaves/trash/kio_trash.cpp, line 617
> > <https://git.reviewboard.kde.org/r/125538/diff/1/?file=410023#file410023line617>
> >
> >     Maybe use qCDebug? So it can be disabled and so.

Trash doesn't use categorized logging atm so I decided to use qDebug.

IMHO categorized logging should be added in a separate patch instead.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125538/#review86411
-----------------------------------------------------------


On Oct. 6, 2015, 9:40 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125538/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 9:40 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Gives the user info about the trash occupancy when opening the trash
> 
> 
> Diffs
> -----
> 
>   src/ioslaves/trash/kio_trash.h e6160c4 
>   src/ioslaves/trash/kio_trash.cpp 7ca8ad0 
>   src/ioslaves/trash/trashimpl.h 9881d8e 
>   src/ioslaves/trash/trashimpl.cpp 5a2832a 
> 
> Diff: https://git.reviewboard.kde.org/r/125538/diff/
> 
> 
> Testing
> -------
> 
> Works fine (with and without maximum size limit)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151006/c14d17e8/attachment.html>