Review Request 125535: Minor optimizations

Aleix Pol Gonzalez aleixpol at kde.org
Mon Oct 5 23:26:56 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125535/#review86399
-----------------------------------------------------------



src/k7zip.cpp (line 2567)
<https://git.reviewboard.kde.org/r/125535/#comment59521>

    .fill() and remove the loop



src/k7zip.cpp (line 2574)
<https://git.reviewboard.kde.org/r/125535/#comment59522>

    .fill



src/k7zip.cpp (line 2580)
<https://git.reviewboard.kde.org/r/125535/#comment59523>

    .fill


- Aleix Pol Gonzalez


On Oct. 6, 2015, 12:34 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125535/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 12:34 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> A few reserve calls
> A missing &
> QLatin1String -> QStringLiteral
> 
> 
> Diffs
> -----
> 
>   src/kzip.cpp 6053a3b 
>   src/kfilterdev.cpp 85fa940 
>   src/k7zip.cpp 64c6b52 
>   src/ktar.cpp 49a6791 
>   src/karchive.cpp a1cd6a8 
> 
> Diff: https://git.reviewboard.kde.org/r/125535/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151005/7207715a/attachment.html>


More information about the Kde-frameworks-devel mailing list