Review Request 125525: Perform deep copy of QByteArray get_stringlist_reply

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125525/
-----------------------------------------------------------

(Updated Oct. 5, 2015, 8:39 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, kwin and Albert Astals Cid.


Changes
-------

Submitted with commit 246a3d64326ba8a357b12cbe4212b423dced7838 by Martin Gräßlin to branch master.


Repository: kwindowsystem


Description
-------

The code used fromRawData instead of a deep copy which must ensure that
the memory is kept around for the QByteArray and all copies. But the
code did not guarantee that as it frees the raw data. So better do a
deep copy of the data.


Diffs
-----

  src/platforms/xcb/netwm.cpp 3c70ed6baf07c38bf59b8102960e819792e46c93 

Diff: https://git.reviewboard.kde.org/r/125525/diff/


Testing
-------

My KWin unit test does no longer fail


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151005/60ce305e/attachment.html>