Review Request 125325: New widget KCollapsibleGroupBox

[David Edmundson]

> On Oct. 3, 2015, 9:54 p.m., David Faure wrote:
> >

Thanks


> On Oct. 3, 2015, 9:54 p.m., David Faure wrote:
> > tests/kcollapsiblegroupboxtest.cpp, line 35
> > <https://git.reviewboard.kde.org/r/125325/diff/4/?file=409474#file409474line35>
> >
> >     just curious: why?

We don't know which apps will enable it, so it's best to test every widget as though some app might.

This widget doesn't use pixmaps, so it's pretty pointless for now, but it might in future and I want setting this to be a standard thing in all qwidget graphical tests.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review86315
-----------------------------------------------------------


On Oct. 3, 2015, 1:38 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2015, 1:38 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> -------
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> ----------------
> 
> kcollapsiblegroupbox.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151004/d887acf9/attachment.html>