Review Request 125514: Add a web shortcut manager

[Laurent Montel]

> On oct. 4, 2015, 11:52 matin, David Faure wrote:
> > Seems useful to have, I've seen such actions in multiple places, including KHTML and KWebkit (and I know you're coming from kdepim with this).
> > 
> > I'm wondering if the naming couldn't be improved though. This has very little to do with "shortcuts", it only shares the search provider definitions. I'm thinking of KIO::SearchProviderActions, in line with KFileItemActions and KDesktopFileActions.
> > 
> > (or maybe KUriFilterSearchProviderActions, since KUriFilterSearchProvider exists? Although that class is for the plugins, so apps don't really know about it).
> > I suggest to wait for more input before renaming, let's see what others think.

Ok I wait but KUriFilterSearchProviderActions seems good as name


> On oct. 4, 2015, 11:52 matin, David Faure wrote:
> > autotests/webshortcutmenumanagertest.cpp, line 62
> > <https://git.reviewboard.kde.org/r/125514/diff/1/?file=409551#file409551line62>
> >
> >     no way to be more specific about what we expect to see?
> >     
> >     If it's all plugins then indeed it's difficult.

It's specific about config. so we can't be sure that we have specific plugin.
So I verify just that menu is not empty => it generates a correct menu.


> On oct. 4, 2015, 11:52 matin, David Faure wrote:
> > src/widgets/CMakeLists.txt, line 141
> > <https://git.reviewboard.kde.org/r/125514/diff/1/?file=409552#file409552line141>
> >
> >     Shouldn't this be installed as KIO/WebShortcutsMenuManager, to match the classname? In that case, it should be moved to the next list of headers, those that end up under KIO/

indeed I will fix it.


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125514/#review86327
-----------------------------------------------------------


On oct. 4, 2015, 5:44 matin, Laurent Montel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125514/
> -----------------------------------------------------------
> 
> (Updated oct. 4, 2015, 5:44 matin)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> When we select text we can provide a search from internet.
> 
> 
> Diffs
> -----
> 
>   src/widgets/CMakeLists.txt 820cd34 
>   src/widgets/webshortcutsmenumanager.h PRE-CREATION 
>   autotests/webshortcutmenumanagertest.cpp PRE-CREATION 
>   src/widgets/webshortcutsmenumanager.cpp PRE-CREATION 
>   autotests/CMakeLists.txt 989acd4 
>   autotests/webshortcutmenumanagertest.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125514/diff/
> 
> 
> Testing
> -------
> 
> Tested from long time in kdepim.
> I added autotests for it.
> 
> 
> Thanks,
> 
> Laurent Montel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151004/25eae7c0/attachment-0001.html>