Review Request 125503: KCrash: pass cwd to kdeinit when auto-restarting the app via kdeinit.
David Faure
faure at kde.org
Sat Oct 3 20:00:05 UTC 2015
> On Oct. 3, 2015, 6:21 p.m., David Edmundson wrote:
> > src/kcrash.cpp, line 655
> > <https://git.reviewboard.kde.org/r/125503/diff/1/?file=409466#file409466line655>
> >
> > +201 ?
Hmm, good point.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125503/#review86305
-----------------------------------------------------------
On Oct. 3, 2015, 7:59 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125503/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 7:59 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Bugs: 337760
> https://bugs.kde.org/show_bug.cgi?id=337760
>
>
> Repository: kcrash
>
>
> Description
> -------
>
> This was the reason why the unittest failed locally (with kdeinit available)
> while it worked in CI (without kdeinit). The cwd was wrong so the restarted
> program was adding a line to $HOME/kcrashtest_log instead of the one here.
>
>
> Diffs
> -----
>
> src/kcrash.cpp 451267740778d927484f6bbc465918fb4e7510d5
>
> Diff: https://git.reviewboard.kde.org/r/125503/diff/
>
>
> Testing
> -------
>
> autotest now passes for me
>
>
> Thanks,
>
> David Faure
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151003/318e32ec/attachment.html>
More information about the Kde-frameworks-devel
mailing list