Review Request 125502: Add KCrash::initialize() so that apps and the platform plugin can explicitly enable KCrash.

David Edmundson david at davidedmundson.co.uk
Sat Oct 3 18:23:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125502/#review86304
-----------------------------------------------------------


+1 from me


src/kcrash.cpp (line 120)
<https://git.reviewboard.kde.org/r/125502/#comment59452>

    there is a qEnvironmentVariableIsSet


- David Edmundson


On Oct. 3, 2015, 11:52 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125502/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2015, 11:52 a.m.)
> 
> 
> Review request for KDE Frameworks and Harald Sitter.
> 
> 
> Repository: kcrash
> 
> 
> Description
> -------
> 
> Add KCrash::initialize() so that apps and the platform plugin can explicitly enable KCrash.
> 
> 
> Diffs
> -----
> 
>   src/kcrash.h f9b154296e2633d8228996a2ff037864216a229e 
>   src/kcrash.cpp 451267740778d927484f6bbc465918fb4e7510d5 
> 
> Diff: https://git.reviewboard.kde.org/r/125502/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151003/ce3fd8c1/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list