Review Request 125504: KServiceTypeProfile: remove unnecessary factory creation.

David Faure faure at kde.org
Sat Oct 3 13:14:45 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125504/
-----------------------------------------------------------

Review request for KDE Frameworks and Milian Wolff.


Bugs: 353360
    https://bugs.kde.org/show_bug.cgi?id=353360


Repository: kservice


Description
-------

This led to a deadlock in some cases (although I didn't manage to write
a unittest that triggers it). Still, adding the unittest I wrote, it's
always good to have more.

BUG: 353360


Diffs
-----

  autotests/kservicetest.h 62dcbae98b250fc89cff316efb065b4b86c0f0f5 
  autotests/kservicetest.cpp 87cfe6fb73dbec11561e906582920aa7d70a6f6e 
  src/services/kservicetypeprofile.cpp b920e303e8ffdfb7df447e628ab45348f2950c2f 

Diff: https://git.reviewboard.kde.org/r/125504/diff/


Testing
-------


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151003/3b19e772/attachment.html>


More information about the Kde-frameworks-devel mailing list