Review Request 125418: Add method to revert knotifyconfigwidget to default notifications

[David Edmundson]

> On Sept. 27, 2015, 8:21 a.m., Sune Vuorela wrote:
> > src/knotifyconfigwidget.h, line 73
> > <https://git.reviewboard.kde.org/r/125418/diff/1/?file=408544#file408544line73>
> >
> >     This function name for a setter looks weird to me.
> >     setDefaults()
> >     reset()
> >     restoreDefaults()
> >     
> >     would be better names in my opinion. 
> >     
> >     defaults() doesn't look like an action, so it must be a getter.
> 
> David Edmundson wrote:
>     I half agree, It would be better with of verb in there.
>     On the other hand matching KCModule API is a good thing too as then things are consistent.
>     
>     I'll wait for a third opinion and blindly go with whatever that says.
> 
> David Faure wrote:
>     KConfig uses revertToDefault(key).
>     
>     You could use revertToDefaults() here.

Done


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125418/#review86002
-----------------------------------------------------------


On Sept. 27, 2015, 12:42 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125418/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2015, 12:42 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifyconfig
> 
> 
> Description
> -------
> 
> Add method to revert knotifyconfigwidget to defaults
> 
> 
> Diffs
> -----
> 
>   src/knotifyconfigwidget.h dd336bc996008809678a6f44cbefe4bf0761908d 
>   src/knotifyconfigwidget.cpp 72c826de3d4c6984b3daac351e5a9a5a6a5bb1eb 
>   src/knotifyeventlist.h 110e3932fb94528a72cec1da911c734c174e1ba8 
>   src/knotifyeventlist.cpp dd6b6e9d5557fde0b46d980e4078921dd978f13f 
> 
> Diff: https://git.reviewboard.kde.org/r/125418/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151003/62817077/attachment.html>