Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125425/
-----------------------------------------------------------

(Updated Okt. 3, 2015, 7:50 vorm.)


Review request for KDE Frameworks and David Faure.


Changes
-------

I propose to do this in two steps:

1. Move konqpopupmenu.plugin from kde-baseapps to kio (this is what the current version of this review does).
2. Add a new KIOServiceMenuPlugin service type, make it work like KonqPopupMenu/Plugin, and log a warning if a plugin only implements the latter.

I'm willing to also do step 2, but after I had a quick look at the code, I think that KFileItemActions::addServiceActionsTo needs some refactoring first. I currently don't have the time for that, but I think that the absence of service menu plugins should be fixed rather sooner than later, so I think that implementing step 1 first makes sense.

If this is approved, then I will push it together with https://git.reviewboard.kde.org/r/124983/ to minimize the trouble for the translators and see how the installation of the files can be suppressed in lib/konq if the KIO version is high enough.


Bugs: 350769
    https://bugs.kde.org/show_bug.cgi?id=350769


Repository: kio


Description
-------

This is a modified version of the file konqpopupmenuplugin.desktop in kde-baseapps (see https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop for the latest version).

I modified the name to kioservicemenuplugin.desktop because the file has not been Konqueror-specific for quite some time. I also updated the 'Comment' accordingly and removed the outdated translations.

I hope I did that right - any comments are welcome!

Note: Just like https://git.reviewboard.kde.org/r/124983/ this should probably be pushed to master after the tagging for the next version because of the translations. On the one hand, the translation of this 'Comment' might not be that important because the it is not shown anywhere in the UI as far as I know (it is shown in the 'Type' column in Dolphin though when viewing the directory where this file is installed). But on the other hand, it might be better to resolve both context menu issues in the same KIO release. What do others think?


Diffs (updated)
-----

  src/widgets/CMakeLists.txt 820cd34 
  src/widgets/konqpopupmenuplugin.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125425/diff/


Testing
-------

Konsole service actions are shown in the context menu again.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151003/21549ddf/attachment.html>