Review Request 125484: Allow to clear completion history

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125484/#review86250
-----------------------------------------------------------


Looks ok to me, except that KHistoryComboBox also adds such a menu item to the KLineEdit popup. Can you check if it has it twice now? I would expect so. In that case you could remove the action+slot from KHistoryComboBox then? (compare the slots to be sure it's the same logic).

- David Faure


On Oct. 2, 2015, 8:14 p.m., Laurent Montel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125484/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 8:14 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> In a application we can't remove history until we close it. It can be problematic when we add a critical word as password etc.
> 
> 
> Diffs
> -----
> 
>   src/klineedit.h 59cec4e 
>   src/klineedit.cpp 37c079d 
>   src/klineedit_p.h c7b63c6 
> 
> Diff: https://git.reviewboard.kde.org/r/125484/diff/
> 
> 
> Testing
> -------
> 
> Tested in kdepim from long time ago.
> Tested in klineedittest apps.
> 
> 
> Thanks,
> 
> Laurent Montel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151002/3099f28e/attachment.html>