Review Request 125480: KFileWidget: provide a "bigger than minimum" sizeHint.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125480/#review86218
-----------------------------------------------------------


+1 lgtm

- Aleix Pol Gonzalez


On Oct. 2, 2015, 9:58 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125480/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 9:58 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This code is taken from kdelibs4 KFileDialog.
> 
> The too small size hint can be tested by the new kfilewidgettest_gui.cpp.
> I originally hit this when inserting a picture shape into calligra stage,
> the "shape options dialog" is mostly just a KFileWidget, and it was tiny
> every time.
> 
> Change-Id: I7618af127619f0fe0204310d28b6b5ac07bfc5b8
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kfilewidget.h 5b59ea9a57f38da3cb0e94da509d3943ff5a672e 
>   src/filewidgets/kfilewidget.cpp d66040974d244c8dd54649615c9aae05eb3356c8 
> 
> Diff: https://git.reviewboard.kde.org/r/125480/diff/
> 
> 
> Testing
> -------
> 
> Tested with kfilewidgettest_gui
> 
> I actually expected the file dialog to be a little bigger.
> 
> Also I wonder why the config saving doesn't seem to work? IIRC this widget was supposed to remember its own size.
> 
> Also it seems kfilewidgettest_gui doesn't exit when closing the KFileWidget... weird.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151002/91c98e5b/attachment.html>