Review Request 126196: Fix regression caused by RR 125527

Jarosław Staniek staniek at kde.org
Sat Nov 28 23:34:56 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126196/#review88920
-----------------------------------------------------------

Ship it!


Brilliant fix. Thanks a lot, Alex!

- Jarosław Staniek


On Nov. 28, 2015, 11:25 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126196/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2015, 11:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Jarosław Staniek.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Make sure that applications using kcoreaddons_desktop_to_json() that
> depend on reading the MimeType property of the root object still work
> 
> See https://git.reviewboard.kde.org/r/125527/
> 
> 
> Diffs
> -----
> 
>   src/lib/plugin/desktopfileparser.cpp eae91881bafc93b047b81a2b21634223dd5d89f4 
> 
> Diff: https://git.reviewboard.kde.org/r/126196/diff/
> 
> 
> Testing
> -------
> 
> compiles, tests pass
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151128/9fc467ed/attachment.html>


More information about the Kde-frameworks-devel mailing list