Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

[Emmanuel Pescosta]

> On Nov. 26, 2015, 9:20 a.m., David Faure wrote:
> > src/widgets/kurlcompletion.cpp, line 531
> > <https://git.reviewboard.kde.org/r/125988/diff/1/?file=415715#file415715line531>
> >
> >     are you sure this hunk is necessary?
> >     QUrl has no special handling of "." in paths.
> >     So m_fileName = m_kurl.fileName() would also just set it to ".", like your special code does.
> >     
> >     (and if that's right then I don't see the purpose of the two new vars...)
> >     
> >     Wasn't only the last hunk of the patch that really made a difference?

> are you sure this hunk is necessary?

According to the tests yes, I had to add those special handling to make the tests pass.
In the second patch I have added some additional tests to prove that the check "ends with /. or is equal to ." instead of just "ends with ." is needed.

> Wasn't only the last hunk of the patch that really made a difference?

Yes it made a difference, but it didn't fix all the problems, namely:

* KUrlCompletionTest::testLocalAbsolutePath: Completion with '.', should find all hidden folders
* KUrlCompletionTest::testLocalRelativePath: Completion with '.', should find all hidden folders


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125988/#review88860
-----------------------------------------------------------


On Nov. 9, 2015, 9:30 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125988/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 9:30 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 354981
>     https://bugs.kde.org/show_bug.cgi?id=354981
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Currently KUrlCompletion only offers autocompletion for hidden folders when you input at least one additional character after the dot. 
> With this patch all hidden folders will be offered when only a dot is present.
> 
> This behaviour is test covered.
> 
> 
> Diffs
> -----
> 
>   autotests/kurlcompletiontest.cpp ca8563c 
>   src/widgets/kurlcompletion.cpp c6764e4 
> 
> Diff: https://git.reviewboard.kde.org/r/125988/diff/
> 
> 
> Testing
> -------
> 
> All test cases for KUrlCompletion pass
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151128/d9759e73/attachment-0001.html>